Files
claw3d/tests/unit/skillsRemoveExecutor.test.ts
Luke The Dev c3556d2daa fix(security): close remaining path validation gaps (#77)
Harden the SSH agent-state and skill-removal paths to match the local security model, and avoid rejecting valid local workspace skill removals.

Made-with: Cursor

Co-authored-by: iamlukethedev <lucas.guilherme@smartwayslfl.com>
2026-03-27 22:21:41 -05:00

62 lines
1.9 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from "vitest";
import { runSshJson } from "@/lib/ssh/gateway-host";
import { removeSkillOverSsh } from "@/lib/ssh/skills-remove";
vi.mock("@/lib/ssh/gateway-host", () => ({
runSshJson: vi.fn(),
}));
describe("skills remove ssh executor", () => {
const mockedRunSshJson = vi.mocked(runSshJson);
beforeEach(() => {
mockedRunSshJson.mockReset();
});
it("removes skill files via ssh", () => {
mockedRunSshJson.mockReturnValueOnce({
removed: true,
removedPath: "/home/ubuntu/.openclaw/skills/github",
source: "openclaw-managed",
});
const result = removeSkillOverSsh({
sshTarget: "me@host",
request: {
skillKey: "github",
source: "openclaw-managed",
baseDir: "/home/ubuntu/.openclaw/skills/github",
workspaceDir: "/home/ubuntu/.openclaw/workspace-main",
managedSkillsDir: "/home/ubuntu/.openclaw/skills",
},
});
expect(result).toEqual({
removed: true,
removedPath: "/home/ubuntu/.openclaw/skills/github",
source: "openclaw-managed",
});
expect(runSshJson).toHaveBeenCalledWith(
expect.objectContaining({
sshTarget: "me@host",
argv: [
"bash",
"-s",
"--",
"github",
"openclaw-managed",
"/home/ubuntu/.openclaw/skills/github",
"/home/ubuntu/.openclaw/workspace-main",
"/home/ubuntu/.openclaw/skills",
],
label: "remove skill (github)",
input: expect.stringContaining('python3 - "$1" "$2" "$3" "$4" "$5"'),
})
);
const call = mockedRunSshJson.mock.calls[0]?.[0];
expect(call?.input).toContain('managed_skills_root = (state_dir / "skills").resolve(strict=False)');
expect(call?.input).toContain("Remote workspace skill removal is not supported over SSH.");
});
});